Remove data property from fetchMore result #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @cesarsolorzano! I think this is the right thing to do. It probably won't break anything, but we'll have to note it as a breaking change in the changelog because it affects the external API. Can you add a changelog entry please? |
|
Yeah - everyone using fetchMore will have to change their code for this right? We should make sure we write a good migration guide to 1.0 |
|
@helfer done! |
|
This looks great @cesarsolorzano, thanks a lot! 👍 I will merge it later today 🙂 |
jonmagic
reviewed
May 2, 2017
| @@ -4,6 +4,7 @@ Expect active development and potentially significant breaking changes in the `0 | |||
|
|
|||
| ### vNEXT | |||
| - Fix: Update TypeScript Middleware and Afterware interfaces to include a datatype for 'this' in apply function. [PR #1372](https://github.com/apollographql/apollo-client/pull/1372) | |||
| - Breaking: Remove data property from fetchMore result [PR #1416](https://github.com/apollographql/apollo-client/pull/1416) | |||
There was a problem hiding this comment.
Afaict this changelog item did not make it into https://github.com/apollographql/react-apollo/blob/master/Changelog.md which caused me a great deal of confusion on upgrade.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix issue #1384
TODO: