Adding typescript definition for 'this' on Middleware and Afterware apply functions. #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangorra
commented
Mar 7, 2017
- If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
- Update CHANGELOG.md with your change
- Add your name and email to the AUTHORS file (optional)
- If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
helfer
suggested changes
Mar 9, 2017
CHANGELOG.md
Outdated
| @@ -10,7 +10,7 @@ Expect active development and potentially significant breaking changes in the `0 | |||
| - Fix: make sure maybeDeepFreeze is called on results returned from setVariables and refetch [PR #1362](https://github.com/apollographql/apollo-client/pull/1362) | |||
| - Fix: use setTimeout to throw uncaught errors in observer.next and observer.error[PR #1367](https://github.com/apollographql/apollo-client/pull/1367) | |||
| - Remove returnPartialData option [PR #1370](https://github.com/apollographql/apollo-client/pull/1370) | |||
|
|
|||
| - Update TypeScript Middleware and Afterware interfaces to include a datatype for 'this' in apply function. | |||
There was a problem hiding this comment.
Make sure to add the PR number here!
src/transport/afterware.ts
Outdated
| @@ -13,5 +15,5 @@ export interface BatchAfterwareResponse { | |||
| } | |||
|
|
|||
| export interface BatchAfterwareInterface { | |||
| applyBatchAfterware(response: BatchAfterwareResponse, next: Function): any; | |||
| applyBatchAfterware(this: NetworkInterface, response: BatchAfterwareResponse, next: Function): any; | |||
There was a problem hiding this comment.
Is this the correct type or could it be more specific (BatchNetworkInterface)?
src/transport/middleware.ts
Outdated
|
|
||
| export interface MiddlewareRequest { | ||
| request: Request; | ||
| options: RequestInit; | ||
| } | ||
|
|
||
| export interface MiddlewareInterface { | ||
| applyMiddleware(request: MiddlewareRequest, next: Function): void; | ||
| applyMiddleware(this: NetworkInterface, request: MiddlewareRequest, next: Function): void; |
There was a problem hiding this comment.
Also this type. Could it be more specific?
|
Looks great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.