-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update explainer around reducing-bundle-size #11791
Conversation
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will hand this off to Maria, but I really like this addition!
## Why havev a larger library in the first place? | ||
|
||
### What you get | ||
Apollo Client is more than just a simple data fetcher: it is a request/response cache, state manager, and React component integration. Attempting to build a comparable experience to Apollo Client with other libraries would require you to write custom logic, libraries, and components wrappers. Scaling that out to all the components in your application would easily lead to a larger bundle and doing so with a custom and difficult to understand implementation that needs to be maintain by your team. By choosing Apollo Client, you hand off that ownership to a trusted team building Open Source Software since 2016. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Only other thing I'd add to that list of what Apollo Client is is adding something about testing utilities as well. I think that is also an important part of the library and is definitely not something you will ever see in a production bundle.
@Meschreiber when you get a chance, I'd love for you to take a look 🙂 |
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this addition @smyrick and ping @jerelmiller ! Just some suggestions for conciseness.
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's get this merged :)
Uh, it seems I can't push to this branch. Could you please run |
Thank you! |
I wrote this from an internal call. It was good insights that should be on our public docs