Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache override warning output #11483

Merged

Conversation

pipopotamasu
Copy link
Contributor

@pipopotamasu pipopotamasu commented Jan 12, 2024

Fixed: #11482

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@pipopotamasu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Jan 12, 2024

‼️ Deploy request for apollo-client-docs rejected.

Name Link
🔨 Latest commit add3c4c

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 47f382b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pipopotamasu pipopotamasu marked this pull request as ready for review January 12, 2024 19:11
@bignimbus bignimbus changed the title Fix cache override waring output Fix cache override warning output Jan 17, 2024
Copy link
Contributor

@bignimbus bignimbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting this! Since we're in the middle of cutting the 3.9.0 release candidate, I'll hold off on merging

@pipopotamasu
Copy link
Contributor Author

@bignimbus Thank you for your review and approval!

@jerelmiller jerelmiller merged commit 6394dda into apollographql:main Jan 17, 2024
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants