Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setContext link race condition can leak subscriptions #8398

Closed
sofianhn opened this issue Jun 18, 2021 · 0 comments · Fixed by #8399
Closed

setContext link race condition can leak subscriptions #8398

sofianhn opened this issue Jun 18, 2021 · 0 comments · Fixed by #8399
Assignees

Comments

@sofianhn
Copy link
Contributor

Intended outcome:
Subscription cancelled before operation.setContext functions are resolved as part of the setContext link don't advance to the next link creating phantom subscriptions.

Actual outcome:
A Race condition can lead to phantom subscriptions created which results in memory leaks.

How to reproduce the issue:
The test in the PR attached to this ticket is a repro case.

Versions

System:
OS: macOS 10.15.7
Binaries:
Node: 14.8.0 - /usr/local/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.7 - /usr/local/bin/npm
Browsers:
Safari: 14.0

@hwillson hwillson added this to the June 2021 milestone Jun 22, 2021
@benjamn benjamn linked a pull request Jun 22, 2021 that will close this issue
2 tasks
@hwillson hwillson removed this from the MM-2021-06 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants