-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix apollo-on-kubernetes link #5317
fix apollo-on-kubernetes link #5317
Conversation
Warning Rate limit exceeded@nobodyiam has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis pull request focuses on updating the deployment documentation for Apollo services in both English and Chinese languages. The English version involves removing a specific reference to Eureka service discovery, while the Chinese version includes more substantial changes. These changes primarily encompass adding detailed Docker deployment instructions and expanding Kubernetes deployment guidance using Helm Charts, providing clearer and more comprehensive deployment documentation for different environments. Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/zh/deployment/distributed-deployment-guide.md (2)
1274-1275
: Add security best practices for Docker deployment.While the Docker deployment instructions are comprehensive, consider adding the following security-related recommendations:
- Use non-root user inside containers
- Add resource limits (CPU/memory)
- Implement Docker network isolation
- Document security considerations for production deployments
1274-1275
: Enhance Kubernetes deployment documentation with operational guidance.Consider adding the following operational aspects to the Kubernetes deployment section:
- Monitoring and logging setup
- Backup and disaster recovery procedures
- Scaling guidelines
- Troubleshooting guide for common issues
- Production readiness checklist
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/deployment/distributed-deployment-guide.md
(1 hunks)docs/zh/deployment/distributed-deployment-guide.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/en/deployment/distributed-deployment-guide.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
3fc011a
to
a74bc06
Compare
What's the purpose of this PR
fix apollo-on-kubernetes link
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit