Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-client support spring boot 3.0 #4

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

As spring boot 3.0 deprecated the auto-configuration support in spring.factories, we need to use the new way to configure it in the META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports to let apollo-client support spring boot 3.0.

Brief changelog

  • add the new file META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports with content com.ctrip.framework.apollo.spring.boot.ApolloAutoConfiguration

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from a team December 4, 2022 12:06
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #4 (24a68c7) into main (f6670d5) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main       #4      +/-   ##
============================================
- Coverage     67.78%   67.69%   -0.10%     
+ Complexity     1163     1162       -1     
============================================
  Files           165      165              
  Lines          5107     5107              
  Branches        559      559              
============================================
- Hits           3462     3457       -5     
- Misses         1376     1380       +4     
- Partials        269      270       +1     
Impacted Files Coverage Δ
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam nobodyiam force-pushed the spring-boot-3-support branch from f28ac10 to 24a68c7 Compare December 4, 2022 12:09
@nobodyiam nobodyiam merged commit 3940553 into apolloconfig:main Dec 5, 2022
@nobodyiam nobodyiam deleted the spring-boot-3-support branch December 5, 2022 00:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants