-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start to Rev3 CM Production test code #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also get rid of some cruft
need to fix this to reuse from cm_mcu
* Added test command * Able to read temperatures from DC-DC converters * Made first pass at DC-DC I2C test * Ammended I2C regulator test to check reset; added comments and cleaned up a bit * clang-format * turn on CI for this branch * Cleanup following suggestions by Peter * Fix typo in debug message * Moved arbitrary test constant to common location * Committing clang-format changes --------- Co-authored-by: Peter Wittich <wittich@cornell.edu> Co-authored-by: pwittich <pwittich@users.noreply.github.com>
mostly to nudge the CI
mcoshiro
reviewed
Jan 9, 2025
mcoshiro
reviewed
Jan 9, 2025
mcoshiro
reviewed
Jan 9, 2025
Okay, I checked over everything, and for the things I understand, everything looks pretty reasonable. For the things I don't understand, they at least look analogous to the cm_mcu project. |
mcoshiro
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of code for production testing, in a new binary in
projects/prod_test
.