-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(go): improve go core library test validators to improve test validation #79
perf(go): improve go core library test validators to improve test validation #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the comments.
General Comments:
- How was this tested?
- I appreciate the small size of the commits
- Does byte matching accurately reflect the kind of testing we want to do? It's good for contract testing but are we not going to test unmarshalling and marshalling? What about models?
- Could we have solved some of these issues by changing
api-tester
?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
A. RawBodyMatcher
B. KeysBodyMatcher
C. KeysAndValuesBodyMatcher
Why
During the implementation of handling Datetime Format cases in the OAF implementation, I identified a loophole in the test validation process of go core library.
This issue affects the accuracy and reliability of the tests generated for the Go SDKs, potentially leading to incorrect validation of Go SDKs tests. It is crucial to address this issue promptly to ensure the correctness of the generated tests and the overall functionality of the Go SDKs.
Type of change
Select multiple if applicable.
Dependency Change
Existing dependencies are removed.
Breaking change
No breaking change were introduced.
Testing
Existing tests are updated to test the updated implementation.
Checklist