Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(union-type-cases-nullable): updates utility functions to null values #60

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat(union-type-cases-nullable): updates utility functions to null values #60

merged 1 commit into from
Mar 5, 2024

Conversation

asadali214
Copy link
Collaborator

@asadali214 asadali214 commented Mar 5, 2024 •
edited
Loading

What

This PR adds handling for missing nullable cases in union-type utilities, it also adds unit tests to cover these features

Why

We were missing the handling for inner nullable cases in union type combinations

Closes #59

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adhares to the following guideline

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 requested a review from saeedjamshaid March 5, 2024 07:54
@asadali214 asadali214 self-assigned this Mar 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@asadali214 asadali214 merged commit 84124c2 into main Mar 5, 2024
2 checks passed
@asadali214 asadali214 deleted the 59-union-type-nullable-cases branch March 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedjamshaid saeedjamshaid saeedjamshaid approved these changes

Assignees

@asadali214 asadali214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing nullable cases handling for union types utilities
2 participants
@asadali214 @saeedjamshaid