Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil returned for status code 4XX-5XX #58

Merged

Conversation

mrafnadeem-apimatic
Copy link
Contributor

What

Call() functions will now always return HTTP Response.

Why

See the issue below.

Closes #57

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Testing

I ran all the unit tests.

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@mrafnadeem-apimatic mrafnadeem-apimatic self-assigned this Mar 5, 2024
@mrafnadeem-apimatic mrafnadeem-apimatic linked an issue Mar 5, 2024 that may be closed by this pull request
5 tasks
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrafnadeem-apimatic mrafnadeem-apimatic merged commit 5648514 into main Mar 5, 2024
2 checks passed
@mrafnadeem-apimatic mrafnadeem-apimatic deleted the 57-fix-nil-returned-for-status-code-4xx-5xx branch March 5, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Calls Should Return Responses Even if Status Code is 4XX or 5XX
2 participants