Response body doesn't appear to log correctly in SDKLogger

[zbuchheit]

Describe the bug
A clear and concise description of what the bug is.

Where did you find this bug?

• ApiError Package
• Https Package
• TestHelper Package
• Utilities Package
• Logger Package

Expected behavior
I would expect the response body to be correctly logged

To Reproduce
Steps to reproduce the bug:

Code Link
It appears the issue stems from the below code. Body is type io.ReadCloser so this doesn't work correctly.

go-core-runtime/logger/sdkLogger.go

Line 121 in b368c82

if bodyBytes, err := json.Marshal(response.Body); err == nil {

Library version number
For example: 0.1.1

Environmental details
For example:
OS: Linux
Runtime version: GO 1.18

Additional context
Add any other context about the problem here.

[haseeb-mhr]

@zbuchheit Thank you for reporting this issue!
To help us better diagnose the problem, please share sample inputs or code snippets that consistently reproduce the issue. Alternatively, please elaborate on the differences between the expected and actual log outputs you're observing.

[zbuchheit]

I don't suspect any use of logging a body here should work. Do you have an example of logging the body of a response successfully? I don't think you can json.Marshal(response.Body); and it work. In my testing, json.Marshal ends up just converting response.Body to be {}

[zbuchheit]

have you been able to replicate the behavior @haseeb-mhr

[haseeb-mhr]

@zbuchheit Thank you for bringing this to our attention. I have replicated the behavior and working on implementing a fix for it.

[zbuchheit]

great news! Thank you!

[haseeb-mhr]

@zbuchheit The changes have been released. Please bump to the latest version to incorporate the fix. Let me know if you encounter any further issues!