Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): correctly log response Body in SDK Logger #94

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

haseeb-mhr
Copy link
Collaborator

What

This PR resolves an issue where the SDKLogger failed to log the response correctly. The logging mechanism has been improved to ensure accurate and complete logging of responses, aiding in debugging and monitoring.

Why

Incorrect or incomplete logging of responses made it challenging to debug issues and track API behavior effectively. Fixing this issue provides developers with better visibility into the SDK's operations, enabling more efficient problem diagnosis.

Closes #93

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Breaking change

No breaking changes were introduced in this PR.

Testing

Added new unit tests for the updated logging mechanism.

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@haseeb-mhr haseeb-mhr added the bug Something isn't working label Dec 10, 2024
@haseeb-mhr haseeb-mhr self-assigned this Dec 10, 2024
@haseeb-mhr haseeb-mhr linked an issue Dec 10, 2024 that may be closed by this pull request
5 tasks
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@haseeb-mhr haseeb-mhr marked this pull request as ready for review December 10, 2024 12:41
asadali214
asadali214 previously approved these changes Dec 11, 2024
@haseeb-mhr haseeb-mhr merged commit 90327c1 into main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response body doesn't appear to log correctly in SDKLogger
2 participants