Make hash and signature algorithm mapping better. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitlockjc
approved these changes
Sep 1, 2017
| alg = HashAlgorithms.get().getByJavaHashName(nodeAlgorithm); | ||
| } | ||
| if (alg == null) { | ||
| throw Utils.makeError(cx, ctorObj, "Digest method not supported"); |
There was a problem hiding this comment.
Would it make sense to have the digest at the end of the error? For example: Digest method not supported: fake-algo
| @@ -0,0 +1,135 @@ | |||
| /** | |||
| * Copyright 2013 Apigee Corporation. | |||
Use a mapping table like the ones that we use for ciphers already to map "OpenSSL" names to "Java" names. This will make crypto.createHash and crypto.createSign work more like the way that Node.js works.
Make sure that createSign('sha256') is a valid usage
of this method.
3784e8f to
b073466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a mapping table like the ones that we use for ciphers already
to map "OpenSSL" names to "Java" names. This will make
crypto.createHash and crypto.createSign work more like the way
that Node.js works.