Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for API Observability #505

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feat: adds support for API Observability #505

merged 5 commits into from
Oct 30, 2024

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan requested a review from kurtkanaskie July 15, 2024 22:37
@srinandan srinandan added the enhancement New feature or request label Jul 17, 2024
kurtkanaskie
kurtkanaskie requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in code

internal/cmd/observe/sources/get.go Show resolved Hide resolved
internal/cmd/observe/sources/create.go Outdated Show resolved Hide resolved
internal/client/observe/observe.go Show resolved Hide resolved
internal/client/observe/observe.go Outdated Show resolved Hide resolved
internal/cmd/observe/jobs/create.go Outdated Show resolved Hide resolved
kurtkanaskie
kurtkanaskie approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinandan srinandan merged commit b6740e3 into main Oct 30, 2024
4 checks passed
@srinandan srinandan deleted the apiobserve branch October 30, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtkanaskie kurtkanaskie kurtkanaskie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srinandan @kurtkanaskie @ssvaidyanathan