Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tailscale steps order #162

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: Tailscale steps order #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/deploy_helmfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,20 +94,6 @@ jobs:
- name: clone repository
uses: actions/checkout@v4

- name: Tailscale VPN
uses: tailscale/github-action@v2
if: inputs.enableVpn == 'true'
with:
oauth-client-id: ${{ secrets.TS_OAUTH_CLIENT_ID }}
oauth-secret: ${{ secrets.TS_OAUTH_SECRET }}
tags: tag:ci
version: 1.76.1

# Bug https://github.com/tailscale/github-action/issues/107
#- name: Tailscale sleep workaround
# run: |
# sleep 10

- name: Send notification to slack
if: inputs.slackChannelId != ''
uses: slackapi/slack-github-action@v1.26.0
Expand Down Expand Up @@ -201,6 +187,20 @@ jobs:
- name: setup kubeconfig
run: aws eks update-kubeconfig --name ${{ inputs.eksClusterName }} $OPTIONAL_PARAMS

- name: Tailscale VPN
uses: tailscale/github-action@v2
if: inputs.enableVpn == 'true'
with:
oauth-client-id: ${{ secrets.TS_OAUTH_CLIENT_ID }}
oauth-secret: ${{ secrets.TS_OAUTH_SECRET }}
tags: tag:ci
version: 1.76.1

# Bug https://github.com/tailscale/github-action/issues/107
#- name: Tailscale sleep workaround
# run: |
# sleep 10

Comment on lines +199 to +203
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be removed now, since we have the next step?

- name: wait until Tailscale is ready
if: inputs.enableVpn == 'true'
run: |
Expand Down
Loading