Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: useCall convert bigint in args to string #549

Merged
merged 3 commits into from
Jan 11, 2025
Merged

feat: useCall convert bigint in args to string #549

merged 3 commits into from
Jan 11, 2025

Conversation

DaveVodrazka
Copy link
Contributor

Resolves #548

@DaveVodrazka DaveVodrazka requested a review from fracek as a code owner January 8, 2025 11:22
@fracek
Copy link
Contributor

fracek commented Jan 9, 2025 •
edited
Loading

Thank you for taking the time for a PR! I think we can make it even simpler by converting the args to a string since it's just used to compute the query key.

You will also need to add a change file with pnpm beachball change and lint the file.

@fracek fracek merged commit 62ea4dd into apibara:main Jan 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fracek fracek fracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useReadContract fails on browsers other than Chrome
2 participants
@DaveVodrazka @fracek