This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not complain about indentation if it is a symbol reference
- Loading branch information
Showing
3 changed files
with
22 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,7 +251,7 @@ TEST_CASE("Parse inline payload with symbol reference", "[payload]") | |
SectionParserHelper<Payload, PayloadParser>::parse(SymbolFixture, RequestBodySectionType, report, payload, symbols); | ||
|
||
REQUIRE(report.error.code == Error::OK); | ||
REQUIRE(report.warnings.size() == 1); | ||
REQUIRE(report.warnings.size() == 0); | ||
|
||
REQUIRE(payload.name.empty()); | ||
REQUIRE(payload.description == "Foo"); | ||
|
@@ -278,7 +278,7 @@ TEST_CASE("Parse inline payload with symbol reference with foreign content", "[p | |
SectionParserHelper<Payload, PayloadParser>::parse(source, RequestBodySectionType, report, payload, symbols); | ||
|
||
REQUIRE(report.error.code == Error::OK); | ||
REQUIRE(report.warnings.size() == 3); // ignoring foreign entry | ||
This comment has been minimized.
Sorry, something went wrong.
zdne
Contributor
|
||
REQUIRE(report.warnings.size() == 1); // ignoring foreign entry | ||
|
||
REQUIRE(payload.name.empty()); | ||
REQUIRE(payload.description == "Foo"); | ||
|
1 comment
on commit 6fe41fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again for a code review, and communication clarity – it would help if you provide a snippet of a blueprint and summary of the behavior pre and after behavior
Please add source code comment – explanation of the purpose of this function (what it does)