-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
I would say it is for any and all examples that are worthy. If they are part of the "course" they should be numbered where the lower number the more fundamental topic of the example (so maybe this is one with a fairly high number) |
|
||
**-- or --** | ||
|
||
Defined by an action [name (identifier)](#def-identifier) followed by an [HTTP request method][httpmethods] and [URI template][uritemplate] enclosed in square brackets `[]`. This is also known by the name *Inline Action*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove "This is also known by the name Inline Action."
Blockers are my comments above and missing example both in specification and in the examples folder. Also it would be good to explain action a resource affordance represented by link transition. Distinguishing state transition within the same resource Feel free to spend some time studying the state transition topic as it is fundamental principle of REST architecture. |
032ad34
to
6a26d7a
Compare
Updated. |
f49da92
to
915dc74
Compare
@@ -0,0 +1,66 @@ | |||
FORMAT: 1A | |||
|
|||
# Inline Action API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So while we use this name "internally" I do not think we should communicate is as a (new) concept. There is no such a thing as inlined transitions or affordances. I would simply name this example as "Advanced Action"
Solid kick-off. Although I think in needs a little bit of touch – Since we are introducing the term "state transition" here for the first time, if I am correct, I think it would be good to mention somewhere in the lead that Action as such is a state transition.. |
915dc74
to
1413bc0
Compare
Updated. |
1413bc0
to
2800182
Compare
FORMAT: 1A | ||
|
||
# Advanced Action API | ||
An action in a resource in the API Blueprint can be considered as a state transition. This API example demonstrates that a resource can contain a state transition to another resource. This allows us to show that the resource `Task` can afford an action that is not limited to the resource `Task`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An action in a resource in the API Blueprint can be considered as a state transition
A resource action is – in fact – a state transition.
This API example demonstrates that a resource can contain a state transition to another resource.
This API example demonstrates an action – state transition – to another resource.
This allows us to show that the resource
Task
can afford an action that is not limited to the resourceTask
.
I would remove this sentence completely
In the specification's resource section (10), there is the following statement:
I think this needs to be reworded as I don't believe it applies anymore anymore, given the following example: ## User [/users/{username}]
+ Parameters
+ username...
### Create a User [POST /users] |
@kylef good catch! @pksunkara please take this into account |
Updated. |
FORMAT: 1A | ||
|
||
# Advanced Action API | ||
A resource action is – in fact – a state transition. This API example demonstrates that an action - state transition - to another resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence does not make sense. Please re-read it loud & then improve it.
Please fix the example. |
51bd529
to
533de80
Compare
Oops. Forgot to remove the word |
For @zdne to review & merge.
I was unable to decide about adding an example API showing the inline action in the
examples
folder. Please correct me if I am wrong, but theexamples
folder is for the major things, right?