chore: definable of openresty version #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leslie-tsang
approved these changes
Aug 15, 2023
soulbird
reviewed
Aug 15, 2023
| @@ -4,6 +4,11 @@ set -x | |||
|
|
|||
| version=${version:-0.0.0} | |||
|
|
|||
| OPENRESTY_VERSION=${OPENRESTY_VERSION:-1.21.4.1} | |||
There was a problem hiding this comment.
What is the difference between OPENRESTY_VERSION and version？
There was a problem hiding this comment.
It is the version of apisix-base.
version => apisix-base
openresty_version => openresty
soulbird
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some dependencies that will run
build-apisix-base.sh.For example, when upgrading to openrsty for
apisix-nginx-module,CI operation relies on
build-apisix-base.sh, due to hard coding, the file content can only be forcibly replaced.