tickPlacement: 'between' caused chart to crash #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gl.seriesX[0].length() was effectively used to size a number of temporary arrays in Scales.scaleMultipleYAxes() but it appears that gl.seriesX is not populated if tickPlacement: 'between' is configured, so this initialization now uses gl.datapoints instead. Removed a duplicate version of a function that was left behind during previous refactoring: Scales.setSeriesYAxisMappings() CoreUtils.setSeriesYAxisMappings() Both were identical except for a loop at the end of CoreUtils.setSeriesYAxisMappings() which set default series group names. Therefore removing Scales.setSeriesYAxisMappings() and substituting the call to it should have no net effect. This appears to be the case from testing.
junedchhipa
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 4704
gl.seriesX[0].length()was effectively used to size a number of temporary arrays inScales.scaleMultipleYAxes()but it appears that gl.seriesX is not populated iftickPlacement: 'between'is configured, so this initialization now usesgl.datapointsinstead.Duplicate function
Removed a duplicate version of a function that was left behind during previous refactoring:
Both were identical except for a loop at the end of
CoreUtils.setSeriesYAxisMappings()which set default series group names. Therefore removingScales.setSeriesYAxisMappings()and substituting the call to it should have no net effect. This appears to be the case from testing.Fixes #4704
Fixes #4699
Type of change
Checklist: