Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with exporting to CSV when categories are null #4394

Merged

Conversation

yungfox
Copy link
Contributor

@yungfox yungfox commented Apr 9, 2024

New Pull Request

I encountered a bug while attempting to export chart data to CSV from a line chart that had null datetime categories and values (to show inconsistencies of data over time), and I was getting the same error as described on #2101, #2185 and #3247. My fix simply checks if the current category is null and moves on to the next if such is the case.

Fixes #2101, #2185 and #3247.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit a7e0429 into apexcharts:main Apr 21, 2024
@yungfox yungfox deleted the feature/export-csv-null-categories branch April 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't export CSV on line graphs, getting errror "i.split is not a function"
2 participants