MonotoneCubic paths feature completion #4390
Merged
+1,249
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
The monotoneCubic paths feature is now complete to the same level as 'straight' and 'smooth' paths for chart types: Line, Area, RangeArea:
Refactored the createPaths() monotoneCubic branch. Several other tidy-up fixes to enable this to work.
Fix libs/monotone-cubic.js splice.slice():
Was crashing on single point slices.
NEEDS TO BE PUSHED UPSTREAM.
New sample to verify most of the above. The rangeArea series have embedded nulls (at start, end and middle) plus forecast data points that were an issue previously for monotoneCubic.
The initial aim was to fix the following sample chart that broke at version 3.45.1 (shown fixed):
Type of change
Checklist: