Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backup cross-namespace recovery fail when restoring from opsRequest. #8931

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: backup cross-namespace recovery fail when restoring from opsRequest. #8931

merged 2 commits into from
Feb 18, 2025

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner February 14, 2025 08:32
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 14, 2025
@wangyelei wangyelei linked an issue Feb 14, 2025 that may be closed by this pull request
[BUG] Error recovering cluster to another cluster in a different namespace #8929
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (1602bfb) to head (e6e265c).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/restore.go 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8931      +/-   ##
==========================================
+ Coverage   60.44%   61.56%   +1.11%     
==========================================
  Files         381      415      +34     
  Lines       46212    50984    +4772     
==========================================
+ Hits        27931    31386    +3455     
- Misses      15610    16737    +1127     
- Partials     2671     2861     +190
Flag Coverage Δ
unittests 61.56% <66.66%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 17, 2025
@wangyelei wangyelei merged commit af6fa75 into main Feb 18, 2025
36 checks passed
@wangyelei wangyelei deleted the bugfix/restore_cros_namespace branch February 18, 2025 01:50
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.3 milestone Feb 18, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13381622930

apecloud-bot pushed a commit that referenced this pull request Feb 18, 2025
@wangyelei
fix: backup cross-namespace recovery fail when restoring from opsRequ…
a720c7e 
…est. (#8931)

(cherry picked from commit af6fa75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

@shanshanying shanshanying shanshanying approved these changes

Assignees
No one assigned
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.3
Development

Successfully merging this pull request may close these issues.

[BUG] Error recovering cluster to another cluster in a different namespace
4 participants
@wangyelei @apecloud-bot @zjx20 @shanshanying