Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the cluster controller panic #8913

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

leon-inf
Copy link
Contributor

close #8912

@leon-inf leon-inf added this to the Release 1.0.0 milestone Feb 13, 2025
@leon-inf leon-inf requested a review from a team as a code owner February 13, 2025 02:54
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Feb 13, 2025
@leon-inf leon-inf force-pushed the bugfix/cluster-controller-panic branch from 30d2fe7 to 18c5104 Compare February 13, 2025 05:44
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.49%. Comparing base (be1334d) to head (fe118bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lers/apps/cluster/transformer_cluster_component.go 52.17% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8913      +/-   ##
==========================================
+ Coverage   60.25%   60.49%   +0.24%     
==========================================
  Files         382      382              
  Lines       46483    46496      +13     
==========================================
+ Hits        28007    28129     +122     
+ Misses      15792    15680     -112     
- Partials     2684     2687       +3     
Flag Coverage Δ
unittests 60.49% <52.17%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 14, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Feb 14, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 14, 2025
@leon-inf leon-inf merged commit e026f1c into main Feb 14, 2025
35 checks passed
@leon-inf leon-inf deleted the bugfix/cluster-controller-panic branch February 14, 2025 08:08
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13325074165

apecloud-bot pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] when applying clusters of the same name but for differenet addons, KB goes crash
4 participants