-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure GeneratePassword returns password with mixed cases #8904
fix: ensure GeneratePassword returns password with mixed cases #8904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8904 +/- ##
==========================================
- Coverage 60.28% 60.18% -0.10%
==========================================
Files 376 387 +11
Lines 45858 46865 +1007
==========================================
+ Hits 27645 28208 +563
- Misses 15614 15958 +344
- Partials 2599 2699 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
27b892b
to
f7db26f
Compare
/cherry-pick release-1.0-beta |
🤖 says: cherry pick action finished successfully 🎉! |
(cherry picked from commit 972c0d8)
/cherry-pick release-0.9 |
🤖 says: Error cherry-picking. |
🤖 says: |
fix #8837
Problem: Mixed-case password doesn't guarantee having both uppercase and lowercase.
Fix: Introduce EnsureMixedCase() post-processor to guarantee at least one uppercase and one lowercase.
Testing: Verified consistent generation with same seed, plus enforced mixed-case distribution.