Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove incorrect comments for the offlineInstances field #8899

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners February 8, 2025 08:44
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 8, 2025
@wangyelei
Copy link
Contributor Author

fix #8832

@wangyelei wangyelei changed the title chore: remove incorrect comments for the offlineInstances field chore: remove incorrect explanatory note for the offlineInstances field Feb 8, 2025
@wangyelei wangyelei changed the title chore: remove incorrect explanatory note for the offlineInstances field chore: remove incorrect comments for the offlineInstances field Feb 8, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (e80c30c) to head (a44172d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8899      +/-   ##
==========================================
+ Coverage   60.39%   60.42%   +0.03%     
==========================================
  Files         382      382              
  Lines       46448    46448              
==========================================
+ Hits        28050    28067      +17     
- Misses      15697    15706       +9     
+ Partials     2701     2675      -26     
Flag Coverage Δ
unittests 60.42% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit e9bb3a7 into main Feb 10, 2025
36 checks passed
@wangyelei wangyelei deleted the bugfix/correct_note branch February 10, 2025 06:09
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.3 milestone Feb 10, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13234660019

apecloud-bot pushed a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Setting instances to offline will remove PVCs, inconsistent with API Docs.
4 participants