Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor parameters partⅣ: parameters-related controller impl #8619

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 8a53165 to c4b2076 Compare December 10, 2024 12:11
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.01399% with 486 lines in your changes missing coverage. Please review.

Project coverage is 60.66%. Comparing base (5b0d594) to head (0f9f06e).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
controllers/parameters/policy_util.go 37.75% 141 Missing and 14 partials ⚠️
...ollers/parameters/componentparameter_controller.go 54.54% 43 Missing and 12 partials ⚠️
controllers/parameters/reconfigure_controller.go 10.16% 51 Missing and 2 partials ⚠️
controllers/parameters/config_util.go 51.47% 29 Missing and 4 partials ⚠️
controllers/parameters/parameter_util.go 82.55% 21 Missing and 9 partials ⚠️
...lers/parameters/parametersdefinition_controller.go 67.74% 21 Missing and 9 partials ⚠️
pkg/configuration/config_manager/handler_util.go 61.03% 23 Missing and 7 partials ⚠️
controllers/parameters/parameter_controller.go 85.07% 16 Missing and 4 partials ⚠️
controllers/parameters/reconcile_task.go 84.49% 13 Missing and 7 partials ⚠️
...llers/parameters/paramconfigrenderer_controller.go 85.32% 11 Missing and 5 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8619      +/-   ##
==========================================
- Coverage   61.07%   60.66%   -0.41%     
==========================================
  Files         377      381       +4     
  Lines       45409    45204     -205     
==========================================
- Hits        27732    27425     -307     
- Misses      15049    15171     +122     
+ Partials     2628     2608      -20     
Flag Coverage Δ
unittests 60.66% <66.01%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from c4b2076 to 75ef901 Compare December 10, 2024 13:42
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch from de53cf4 to 2fca37e Compare December 11, 2024 06:59
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 75ef901 to 0d108f2 Compare December 11, 2024 07:01
@sophon-zt sophon-zt marked this pull request as ready for review December 11, 2024 08:35
@sophon-zt sophon-zt marked this pull request as draft December 12, 2024 02:24
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 0d108f2 to 31b29ca Compare December 12, 2024 02:25
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch from 9bca90e to 4f6ba57 Compare December 25, 2024 04:14
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 4e0d6a2 to 0f9f06e Compare December 25, 2024 05:06
@shanshanying shanshanying added this to the Release 1.0.0 milestone Jan 3, 2025
@github-actions github-actions bot modified the milestones: Release 1.0.0, Release 0.9.3 Jan 14, 2025
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch 2 times, most recently from bb402b5 to 96c9448 Compare February 14, 2025 08:41
Base automatically changed from support/improvement-parameters-api-part1 to main February 14, 2025 09:04
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants