Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support redis cluster switchover and optimize sentinel switchover #1408

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

Y-Rookie
Copy link
Contributor

No description provided.

@Y-Rookie Y-Rookie requested review from leon-inf and a team as code owners January 14, 2025 09:06
@Y-Rookie Y-Rookie marked this pull request as draft January 14, 2025 09:06
@Y-Rookie
Copy link
Contributor Author

issue: apecloud/kubeblocks#8758

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4d507c7) to head (02f0c23).

Files with missing lines Patch % Lines
...ons/redis/scripts-ut-spec/redis_switchover_spec.sh 0.00% 222 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1408    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         69      69            
  Lines       6706    6908   +202     
======================================
- Misses      6706    6908   +202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie Y-Rookie marked this pull request as ready for review January 15, 2025 07:31
@Y-Rookie Y-Rookie merged commit c211bec into main Jan 15, 2025
25 checks passed
@Y-Rookie Y-Rookie deleted the support/support-redis-cluster-switchover branch January 15, 2025 08:18
@Y-Rookie
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: Error cherry-picking.

Auto-merging addons/redis/scripts/redis-switchover.sh
CONFLICT (content): Merge conflict in addons/redis/scripts/redis-switchover.sh
error: could not apply c211bec... chore: support redis cluster switchover and optimize sentinel switchover (#1408)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

@apecloud-bot
Copy link
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/12784192349

Y-Rookie added a commit that referenced this pull request Jan 15, 2025
@Y-Rookie
Copy link
Contributor Author

Y-Rookie commented Jan 15, 2025

🤖 says: ‼️ cherry pick action failed.See: https://github.com/apecloud/kubeblocks-addons/actions/runs/12784192349

pick at: #1414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants