[ZEPPELIN-5973] Bump Livy 0.8.0-incubating #4678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Nov 7, 2023
| LIVY_VERSION="${1}" | ||
| SCALA_VERSION_SUFFIX="" | ||
| if [ $(version $LIVY_VERSION) -ge $(version "0.8.0") ]; then | ||
| SCALA_VERSION_SUFFIX="_${2}" |
There was a problem hiding this comment.
since 0.8.0, livy binary zip contains scala suffix
https://dist.apache.org/repos/dist/release/incubator/livy/0.7.1-incubating/apache-livy-0.7.1-incubating-bin.zip
https://dist.apache.org/repos/dist/release/incubator/livy/0.8.0-incubating/apache-livy-0.8.0-incubating_2.11-bin.zip
pan3793
commented
Nov 7, 2023
| @@ -17,12 +17,20 @@ | |||
| # | |||
|
|
|||
| if [[ "$#" -ne 1 ]]; then | |||
| echo "usage) $0 [livy version]" | |||
| echo "usage) $0 <livy version> [scala version]" | |||
There was a problem hiding this comment.
usually, <arg> represent the required arg, but [arg] represent the optional arg
df870df to
e8163e4
Compare
|
@jongyoul @zjffdu actually, we can refactor the test code of livy module by using a sub-process to call I have a half-done PoC locally, if you don't mind, I will continue it when I have free time. Or if you think it's not a good idea, then let's keep it as-is. |
|
I do not use livy. If there is a way to simplify the test execution we should take it. Currently the test execution is very specific. |
1 task
|
Done with #4743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Apache Livy 0.8.0-incubating was released at 2023-10-10, this PR aims to upgrade the built-in livy to the latest one.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-5973
How should this be tested?
Pass CI
Screenshots (if appropriate)
Questions: