[microTVM][tutorial] Add ENV variable to enable testing on physical hardware #9993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b12b480 to
68ac9e3
Compare
gromero
requested changes
Jan 24, 2022
There was a problem hiding this comment.
Hi @mehrdadh. Thanks for the change. That's quite helpful indeed (not only for the nightly build :) ).
I've just would prefer to not construct and use the list comprehension and maybe use default for os.getenv() (please see the comment inline). Otherwise LGTM!
areusch
approved these changes
Jan 24, 2022
gromero
reviewed
Jan 24, 2022
| boards = json.load(f) | ||
|
|
||
| BOARD = os.getenv("TVM_MICRO_BOARD", default="nucleo_f746zg") | ||
| TARGET = tvm.target.target.micro(boards[BOARD]["model"]) |
There was a problem hiding this comment.
@mehrdadh This is now out of use_physical_hw scope, so it will overwrite the previous TARGET value. Is that intentional?
There was a problem hiding this comment.
nope, that was incorrect. fixed it.
Thanks!
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
…ardware (apache#9993) * Add env variable to micro tflite tutorial * Address @gromero comments * address @areusch comment * fix scope * trigger * trigger
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…ardware (apache#9993) * Add env variable to micro tflite tutorial * Address @gromero comments * address @areusch comment * fix scope * trigger * trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes micro_tflite.py to enable testing this tutorial on physical hardware.