Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the tensorflow frontend _test_spop_resource_variables to supp… #9978

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ophirfrish
Copy link
Contributor

…ort tensoflow 2.6

On tensorflow 2.4 the test is expected to fail as the generated graph is not frozen.
On tensorflow 2.6 the generated graph is identified as frozen, therefore the test is not needed.

cc @areusch @leandron @Mousius @gromero for reviews

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I'd like to get @jroesch opinion if possible, and I think we can leave this open at least a couple days more.

We left a comment in #5617 but didn't get any reply, so this is why we're making this test conditional to < TF 2.6.

@masahi
Copy link
Member

masahi commented Jan 26, 2022

Pleae kick another CI job. Can we merge this now?

…ort tensoflow 2.6

On tensorflow 2.4 the test is expected to fail as the generated graph is not forzen.
On tensorflow 2.6 the generated graph is identified as frozen, therefore the test is not needed
@ophirfrish ophirfrish force-pushed the tvmc-upgrade-test-spop branch from 872dedb to 092b235 Compare January 26, 2022 10:48
@github-actions github-actions bot requested review from Mousius and leandron January 26, 2022 10:49
@leandron leandron merged commit cc8a7a2 into apache:main Jan 26, 2022
sunggg pushed a commit to sunggg/tvm that referenced this pull request Jan 29, 2022
…ort tensoflow 2.6 (apache#9978)

On tensorflow 2.4 the test is expected to fail as the generated graph is not forzen.
On tensorflow 2.6 the generated graph is identified as frozen, therefore the test is not needed
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
…ort tensoflow 2.6 (apache#9978)

On tensorflow 2.4 the test is expected to fail as the generated graph is not forzen.
On tensorflow 2.6 the generated graph is identified as frozen, therefore the test is not needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants