-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU] Support different constant datatypes #9626
Conversation
7d6e8ef
to
d49e9e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some comments from the 'enlightenment' category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ekalda!
d49e9e1
to
130ce9c
Compare
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant. Change-Id: I99e34fe17905b1bb7d916e346cebfc324e3a2a0c
Change-Id: I8432f3d9dcc1001bbad40b76127075a1019197d4
Change-Id: I9b8b9df3af27023f60ef4934a918d40140a9534f
130ce9c
to
d785a16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is merged! Thanks @ekalda @lhutton1 @NicolaLancellotti. |
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph.
A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Note: this PR is dependent on #9576 so contains the contents of that PR also.cc @manupa-arm @ekalda @mbaret @NicolaLancellotti @dchauhan-arm