New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR] Add type hint for TIR #9432

Merged

junrushao merged 32 commits into apache:main from shingjan:tir-type-hint

Nov 9, 2021

shingjan commented Nov 2, 2021 •

edited

Loading

This PR intends to add type hinting and enable auto-completion for TIR and namespace tvm.script.tir as T as a follow-up PR for this.

Co-authored-by: Zihao Ye <zihaoye.cs@gmail.com>

cc: @vinx13 @junrushao1994

junrushao reviewed

View reviewed changes

python/tvm/tir/__init__.pyi Outdated Show resolved Hide resolved

shingjan requested a review from junrushao

November 2, 2021 20:45

shingjan changed the title ~~[TIR][WIP] Add type hint for TIR~~ [WIP][TIR] Add type hint for TIR

shingjan force-pushed the tir-type-hint branch from 6e36a22 to 8c8357b Compare

November 2, 2021 22:58

shingjan changed the title ~~[WIP][TIR] Add type hint for TIR~~ [TIR] Add type hint for TIR

shingjan requested a review from vinx13

November 2, 2021 23:25

Member

vinx13 commented Nov 2, 2021

We will need a few test cases that cover various TIR elements (block related: T.block, T.match_buffer, T.alloc_buffer, T.block_attr, loop related: T.grid, T.serial, T.thread_binding, etc). You can find good examples of TIR scripts written for previous test cases. Please also add script to run the tests to https://github.com/apache/tvm/blob/main/tests/scripts/task_mypy.sh and make sure it can pass the tests

vinx13 requested changes

View reviewed changes

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

mypy.ini Outdated Show resolved Hide resolved

tests/python/unittest/test_tvmscript_type.py Outdated Show resolved Hide resolved

vinx13 reviewed

View reviewed changes

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

shingjan requested a review from vinx13

November 3, 2021 22:55

vinx13 reviewed

View reviewed changes

Member

vinx13 left a comment •

edited

Loading

Would be great to also run pylint over the test file to see the TIR script can pass pylint after adding these stubs. There are also some issues on CI

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

shingjan marked this pull request as ready for review

November 4, 2021 08:17

shingjan requested review from areusch, comaniac, Hzfengsy, icemelon, jroesch, kparzysz-quic, masahi, merrymercy, tqchen, yzhliu, zhiics and ZihengJiang as code owners

November 4, 2021 08:17

shingjan requested a review from vinx13

November 4, 2021 08:17

shingjan force-pushed the tir-type-hint branch from c5eb985 to 57c5b4e Compare

November 4, 2021 17:47

vinx13 reviewed

View reviewed changes

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

tests/python/unittest/test_tvmscript_type.py Outdated Show resolved Hide resolved

shingjan requested a review from vinx13

November 4, 2021 21:15

vinx13 reviewed

View reviewed changes

Member

vinx13 left a comment

would be great to also add test commands to pylint.sh

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

vinx13 reviewed

View reviewed changes

tests/python/unittest/test_tvmscript_type.py Outdated Show resolved Hide resolved

shingjan added 13 commits

November 8, 2021 11:37


          fix CI

ddf594b


          address comments

5b8ff23


          add types

1a9ed89


          mypy --strict

e89ae32


          comments

b6ed67d


          update test comments

77e7839


          linting fix

bbcd16b


          address comments

9fda96e


          add pylint for tir type check

e24d221


          address comments

d7503a5


          move doc string

8f989ca


          comments

4331f04


          getter setter

shingjan force-pushed the tir-type-hint branch from 9f28aed to 8723718 Compare

November 8, 2021 19:37


          add PrimExpr, IterVar and Var

05aa7dd

vinx13 reviewed

View reviewed changes

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved


          add sequence

543caec

shingjan requested a review from vinx13

November 8, 2021 20:54

vinx13 reviewed

View reviewed changes

python/tvm/script/tir/__init__.pyi Outdated Show resolved Hide resolved


          change for handle

8fbbc1b

shingjan requested a review from vinx13

November 8, 2021 22:54

vinx13 approved these changes

View reviewed changes

Member

junrushao commented Nov 9, 2021

Quick question: do we plan to add docstring in this PR?

junrushao merged commit 00b0a81 into apache:main

AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request


          Merge branch 'main' into aluo/qnn/conv2d-transpose-fq2i

da7a16b

* main: (119 commits)
  [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336)
  Fix repository URL in ubuntu_install_rocm.sh (apache#9425)
  Add LLVM-13 installation to Docker setup (apache#9498)
  [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499)
  Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442)
  [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488)
  Add default for split op (apache#9489)
  [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486)
  Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481)
  [Support] Add libinfo into the runtime build (apache#9310)
  Change Call with TIRCallAttrs to call_lowered op (apache#9312)
  [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477)
  [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480)
  [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335)
  [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470)
  Better host handling in CompilationConfig & debug printing (apache#9460)
  [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271)
  [TIR] Add type hint for TIR  (apache#9432)
  [TVMC] Add test for quantized pytorch model (apache#9467)
  [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397)
  ...

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request


          [TIR] Add type hint for TIR (apache#9432)

76d1604

* add init

* get rid of span

* afs header

* update scope_handler

* rm tir/__init__.pyi

* fix linting

* fix lint

* new test case

* add axis module

* address comments

* redefine ty types

* lint

* address comments

* address comments

* fix ci

* add test cases

* fix CI

* address comments

* add types

* mypy --strict

* comments

* update test comments

* linting fix

* address comments

* add pylint for tir type check

* address comments

* move doc string

* comments

* getter setter

* add PrimExpr, IterVar and Var

* add sequence

* change for handle

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request


          [TIR] Add type hint for TIR (apache#9432)

91cafc1

* add init

* get rid of span

* afs header

* update scope_handler

* rm tir/__init__.pyi

* fix linting

* fix lint

* new test case

* add axis module

* address comments

* redefine ty types

* lint

* address comments

* address comments

* fix ci

* add test cases

* fix CI

* address comments

* add types

* mypy --strict

* comments

* update test comments

* linting fix

* address comments

* add pylint for tir type check

* address comments

* move doc string

* comments

* getter setter

* add PrimExpr, IterVar and Var

* add sequence

* change for handle

ylc pushed a commit to ylc/tvm that referenced this pull request


          [TIR] Add type hint for TIR (apache#9432)

000481d

* add init

* get rid of span

* afs header

* update scope_handler

* rm tir/__init__.pyi

* fix linting

* fix lint

* new test case

* add axis module

* address comments

* redefine ty types

* lint

* address comments

* address comments

* fix ci

* add test cases

* fix CI

* address comments

* add types

* mypy --strict

* comments

* update test comments

* linting fix

* address comments

* add pylint for tir type check

* address comments

* move doc string

* comments

* getter setter

* add PrimExpr, IterVar and Var

* add sequence

* change for handle

yangulei pushed a commit to yangulei/tvm that referenced this pull request


          [TIR] Add type hint for TIR (apache#9432)

60ec891

* add init

* get rid of span

* afs header

* update scope_handler

* rm tir/__init__.pyi

* fix linting

* fix lint

* new test case

* add axis module

* address comments

* redefine ty types

* lint

* address comments

* address comments

* fix ci

* add test cases

* fix CI

* address comments

* add types

* mypy --strict

* comments

* update test comments

* linting fix

* address comments

* add pylint for tir type check

* address comments

* move doc string

* comments

* getter setter

* add PrimExpr, IterVar and Var

* add sequence

* change for handle

ylc pushed a commit to ylc/tvm that referenced this pull request


          [TIR] Add type hint for TIR (apache#9432)

89ef251

* add init

* get rid of span

* afs header

* update scope_handler

* rm tir/__init__.pyi

* fix linting

* fix lint

* new test case

* add axis module

* address comments

* redefine ty types

* lint

* address comments

* address comments

* fix ci

* add test cases

* fix CI

* address comments

* add types

* mypy --strict

* comments

* update test comments

* linting fix

* address comments

* add pylint for tir type check

* address comments

* move doc string

* comments

* getter setter

* add PrimExpr, IterVar and Var

* add sequence

* change for handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vinx13 vinx13 approved these changes

junrushao Awaiting requested review from junrushao

areusch Awaiting requested review from areusch

comaniac Awaiting requested review from comaniac

Hzfengsy Awaiting requested review from Hzfengsy

icemelon Awaiting requested review from icemelon

jroesch Awaiting requested review from jroesch

kparzysz-quic Awaiting requested review from kparzysz-quic

masahi Awaiting requested review from masahi

merrymercy Awaiting requested review from merrymercy

tqchen Awaiting requested review from tqchen

yzhliu Awaiting requested review from yzhliu

zhiics Awaiting requested review from zhiics

ZihengJiang Awaiting requested review from ZihengJiang

Labels

None yet