RelayTextPrinter is now non-recursive. ExpandDataflow refactored #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3ef0a9 to
8c5f8e4
Compare
mbrookhart
requested changes
Apr 12, 2021
There was a problem hiding this comment.
I don't understand the ExpandDataFlow refactor. It looks like you rewrote it without actually changing the behavior or using any new APIs? Could you explain the need for the refactor?
I'm not familiar with the RelayTextPrinter, and I've never seen stack overflows when printing models with AsText or python str, I've done models over 150k nodes. What exactly is the use case that overflowed for you? Perhaps I just haven't been calling this class. We'll need a test that hits the bad behavior on the old version
ping @jroesch for the RelayTextPrinter
|
ping @jroesch |
|
Is it possible to add a unit test that triggers this? |
|
To reveal the issue please use a unit test here 7832: |
|
Hi @d-smirnov, sorry, I missed your response last week. Can you add that as a test here? Maybe save the result of AsText as a String and assert it's not empty? |
RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355
Change-Id: Iac69766428d5b9783279cb02a57064fd82842001
Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
0c1022b to
fab2725
Compare
mbrookhart
approved these changes
Apr 23, 2021
|
Thanks @d-smirnov |
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…che#7817) * RelayTextPrinter is now non-recursive. ExpandDataflow refactored RelayTextPrinter is now non-recursive to allow printing larger graphs. ExpandDataflow is generalised to have separate node expander. Change-Id: Id5a3a470fbc8b90822502fbc8d24d534df1ea355 * requested changes Change-Id: Iac69766428d5b9783279cb02a57064fd82842001 * unit test added Change-Id: Id20ae72f9f5f8dd92d4d182360b28156c035e667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelayTextPrinter made non-recursive to allow printing larger graphs ( > ~3000 nodes). There also a small refactoring in ExpandDataflow which was made bit more generalised with "node expander" extracted as separate method.