Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Target] Add cuda tags and unit test #7410

Merged
merged 6 commits into from
Feb 5, 2021
Merged

[Target] Add cuda tags and unit test #7410

merged 6 commits into from
Feb 5, 2021

Conversation

zxybazh
Copy link
Member

@zxybazh zxybazh commented Feb 4, 2021

This commit added cuda tags of most cuda devices for target specification and completed cuda target tag attributes.

@zxybazh
Copy link
Member Author

zxybazh commented Feb 4, 2021

@junrushao1994 Please review, thanks!

junrushao
junrushao requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks to me. Please see my only comment below. Let's get it in quickly after fixing the linter

junrushao
junrushao reviewed Feb 5, 2021
View reviewed changes
@junrushao junrushao self-assigned this Feb 5, 2021
@zxybazh zxybazh requested a review from junrushao February 5, 2021 18:26
junrushao
junrushao approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Xiyou for the first contribution 🎉

@junrushao
Copy link
Member

@comaniac Would you mind taking a second look?

@comaniac comaniac merged commit 4df530d into apache:main Feb 5, 2021
@comaniac
Copy link
Contributor

comaniac commented Feb 5, 2021

Thanks @zxybazh @junrushao1994
It seems to me that we should be consistent to let all fields have a default value (or not), but we could do this later.

@junrushao
Copy link
Member

Thanks @comaniac! For reference, we crawled the information from:

[1] https://developer.nvidia.com/cuda-gpus
[2] https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#features-and-technical-specifications

@junrushao junrushao changed the title Add cuda tags and unit test [Target] Add cuda tags and unit test Feb 5, 2021
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
@zxybazh @alexwong
Add cuda tags and unit test (apache#7410)
5c08802 
* Add cuda tags and unit test

* Add missing space

* Remove extra indent

* Modify macro def position

* Fix clang format

* Fix clang format for set_config
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
@zxybazh @Lokiiiiii
Add cuda tags and unit test (apache#7410)
c8a03a1 
* Add cuda tags and unit test

* Add missing space

* Remove extra indent

* Modify macro def position

* Fix clang format

* Fix clang format for set_config
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
@zxybazh @trevor-m
Add cuda tags and unit test (apache#7410)
7023e8f 
* Add cuda tags and unit test

* Add missing space

* Remove extra indent

* Modify macro def position

* Fix clang format

* Fix clang format for set_config
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

Assignees

@junrushao junrushao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zxybazh @junrushao @comaniac