Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor][VM] Port memory_alloc to c++ #7369

Merged
merged 2 commits into from
Jan 29, 2021
Merged

[Refactor][VM] Port memory_alloc to c++ #7369

merged 2 commits into from
Jan 29, 2021

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Jan 28, 2021

This PR ports the memory manifest pass to C++. This would help reduce compilation time for large models.

@masahi @icemelon9 @anijain2305 @jroesch @mbrookhart @kevinthesun

@masahi
Copy link
Member

masahi commented Jan 29, 2021

Do we want to remove the python version?

@zhiics
Copy link
Member Author

zhiics commented Jan 29, 2021

@masahi oops, I missed a commit. We should be able to remove it

@masahi
Copy link
Member

masahi commented Jan 29, 2021

@zhiics FYI compiling MaskRCNN with C++ ManifestAlloc generates the following warning that I didn't see in the python version. I don't think it matters, just to let you know if you have a clue.

[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used

@zhiics zhiics force-pushed the refactor_memory_alloc branch from 2e08f55 to ff9691f Compare January 29, 2021 07:24
@zhiics
Copy link
Member Author

zhiics commented Jan 29, 2021 •
edited
Loading

@masahi yeah, thanks for reminding. Python pass wouldn't have it because it uses the Python ScopeBuilder. I tried a bit to see why where a LetList was deconstructed but I am not quite sure.

masahi
masahi approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@masahi masahi merged commit 44a071a into apache:main Jan 29, 2021
@masahi
Copy link
Member

masahi commented Jan 29, 2021

thanks @zhiics

@masahi masahi mentioned this pull request Feb 5, 2021
Merged
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
@zhiics @alexwong
[Refactor][VM] Port memory_alloc to c++ (apache#7369)
33c3cf7 
* Port memory_alloc to c++

* remove memory python pass
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@zhiics @electriclilies
[Refactor][VM] Port memory_alloc to c++ (apache#7369)
4547d8c 
* Port memory_alloc to c++

* remove memory python pass
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
@zhiics @Lokiiiiii
[Refactor][VM] Port memory_alloc to c++ (apache#7369)
06b01a9 
* Port memory_alloc to c++

* remove memory python pass
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
@zhiics @trevor-m
[Refactor][VM] Port memory_alloc to c++ (apache#7369)
0fb8a85 
* Port memory_alloc to c++

* remove memory python pass
@zhiics zhiics deleted the refactor_memory_alloc branch April 17, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiics @masahi