Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Type Relation Fixes #7362

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

mbrookhart
Copy link
Contributor

I ran into a couple of bugs in type relations while debugging a model. The first is an issue with dynamic full not checking one of it's inputs for an incomplete type. The second is adding better error handling to Broadcast Type Relations.

cc @jwfromm @electriclilies

@mbrookhart mbrookhart changed the title Type Relation Fixes [Relay] Type Relation Fixes Jan 28, 2021
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@electriclilies
Copy link
Contributor

electriclilies commented Jan 28, 2021

LGTM!

@mbrookhart mbrookhart merged commit b8ad146 into apache:main Jan 28, 2021
@mbrookhart mbrookhart deleted the type_rel_fixes branch January 28, 2021 22:06
@mbrookhart
Copy link
Contributor Author

Thanks @jwfromm @electriclilies

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
* fix an error in the dynamic Full Type Relation

* Add Diagnostic Errors to Broadcast Type Relations
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
* fix an error in the dynamic Full Type Relation

* Add Diagnostic Errors to Broadcast Type Relations
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
* fix an error in the dynamic Full Type Relation

* Add Diagnostic Errors to Broadcast Type Relations
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
* fix an error in the dynamic Full Type Relation

* Add Diagnostic Errors to Broadcast Type Relations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants