[FRONTEND][TENSORFLOW] Helper function to add shapes into the graph. Use temp folder for models and clean it. #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Use tmp folder for model files and clean it.
|
@masahi , @yzhliu & @siju-samuel welcome for a review. |
|
Sorry, I am not familiar with tensorflow. |
|
@nishi-t welcome to review. |
nishi-t
reviewed
Sep 14, 2018
| @@ -76,7 +75,8 @@ | |||
| graph = tf.import_graph_def(graph_def, name='') | |||
| # Call the utility to import the graph definition into default graph. | |||
| graph_def = nnvm.testing.tf.ProcessGraphDefParam(graph_def) | |||
|
|
|||
| # Add shapes to the graph. | |||
| graph_def = nnvm.testing.tf.AddShapesToGraphDef('softmax') | |||
There was a problem hiding this comment.
I have a question. It seems that AddShapesToGraphDef override the graph_def returned from ProcessGraphDefParam. Is it no problem? AddShapesToGraphDef is only used for type checking?
There was a problem hiding this comment.
Thats not a problem as AddShapesToGraphDef take the default graph which is in tf session and is same as graph_def earlier. This step just re freezes the same graph with shapes added .
There was a problem hiding this comment.
Ok, I understand it. Thanks.
|
Thanks @srkreddy1238 @nishi-t , this is now merged |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
…Use tmp folder for model files and clean it. (apache#1697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.