-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microTVM] Update tutorials #13845
[microTVM] Update tutorials #13845
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
8dc572f
to
fdbdc87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for updating these tutorials!
"""Intentionally simple function for making Targets for microcontrollers. | ||
If you need more complex arguments, one should call target.micro directly. Note | ||
that almost all, but not all, supported microcontrollers are Arm-based.""" | ||
if platform == "crt": | ||
return tvm.target.target.micro("host") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we throw a better error if platform
is not "crt"
and board
is None
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thanks!
target = tvm.target.target.micro("host") | ||
# To use physical hardware, replace `board` with another physical micro target, e.g. `nrf5340dk_nrf5340_cpuapp` | ||
# or `mps2_an521` and change the platform type to Zephyr. | ||
# See more more target examples in micro_train.py and micro_tflite.py tutorials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mention these tutorials in text instead of in a code comment? That way we can add clickable links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed it
This PR updates microTVM tutorials to use updated APIs. It also adds an ordering to the tutorials that are useful for first time users. RVM tutorial is also removed as it is not supported anymore.
This PR updates microTVM tutorials to use updated APIs.
It also adds an ordering to the tutorials that are useful for first time users.
RVM tutorial is also removed as it is not supported anymore.