Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX,FIX] onnx Pad operator constant_value omit use default value 0 #13758

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

fantasyRqg
Copy link
Contributor

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 11, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@fantasyRqg
Copy link
Contributor Author

@mbrookhart

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test that exercises the incorrect behavior?

Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndrewZhaoLuo AndrewZhaoLuo merged commit be25803 into apache:main Jan 12, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
apache#13758)

* fix: onnx Pad operator `constant_value` omit use default value 0

* fix format problem

* add onnx Pad unit test

* fix python format

Co-authored-by: rqg <ranqingguo318@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants