[TVMScript] Refactor IRDocsifier #13593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
e853a5e to
c0383d2
Compare
Hzfengsy
approved these changes
Jan 7, 2023
| @@ -294,7 +295,11 @@ void PythonDocPrinter::PrintTypedDoc(const LiteralDoc& doc) { | |||
| } else if (const auto* float_imm = value.as<FloatImmNode>()) { | |||
| // TODO(yelite): Make float number printing roundtrippable | |||
There was a problem hiding this comment.
Do you know if this TODO is resolved?
There was a problem hiding this comment.
Not yet but indeed there is a way forward
8611e47 to
9f99c6d
Compare
This PR refactors the TVMScript printer and includes the following changes: - Consolidate the logics of VarTable into IRDocsifier - Decouple TracedObject into Object and ObjectPath for less syntactic noise - Restructure the folder to ensure logics and consistency Some tests removed because the APIs do not exist any more due to the consolidation.
tqchen
approved these changes
Jan 8, 2023
|
Thanks @junrushao @Hzfengsy ! |
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
This PR refactors the TVMScript printer and includes the following changes: - Consolidate the logics of VarTable into IRDocsifier - Decouple TracedObject into Object and ObjectPath for less syntactic noise - Restructure the folder to ensure logics and consistency Some tests removed because the APIs do not exist any more due to the consolidation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the TVMScript printer and includes the following
changes:
noise
Some tests removed because the APIs do not exist any more due to the
consolidation.