[Arith] Simplify nested if_then_else #12749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49c638c to
175eb97
Compare
|
@tvm-bot rerun |
d50e5c1 to
8876e62
Compare
shingjan
reviewed
Sep 13, 2022
| const PrimExpr& then_expr = op->args[1]; | ||
| const PrimExpr& else_expr = op->args[2]; | ||
| const CallNode* inner_call = then_expr.as<CallNode>(); | ||
| if (inner_call != nullptr && inner_call->op.same_as(tir::builtin::if_then_else())) { |
There was a problem hiding this comment.
Overall LGTM. I wonder if this implies that only one level of nested if_then_else could exist in current TIR structure.
There was a problem hiding this comment.
it supports multiple levels, as this mutator is recursive (then_expr here is from the recursion result)
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
8876e62 to
23dca66
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
[Arith] Simplify nested if_then_else Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @junrushao1994 @spectrometerHBH