Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Fix running gtest on Hexagon hardware #11257

Merged
merged 1 commit into from
May 11, 2022

Conversation

supersat
Copy link
Contributor

@supersat supersat commented May 9, 2022

It appears various QuRT images do not include the pthread_key_delete function. This fixes #11237 by providing an implementation of pthread_key_delete, calling the underlying QuRT API, if it's not already defined. USE_HEXAGON_GTEST is once again defined to enable running tests on hardware.

cc @mehrdadh

@supersat supersat force-pushed the fix-hexagon-gtest-on-hw branch from 56f91f9 to ff5e6c2 Compare May 10, 2022 05:58
@github-actions github-actions bot requested a review from mehrdadh May 10, 2022 05:59
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mehrdadh mehrdadh merged commit 2049185 into apache:main May 11, 2022
@supersat supersat deleted the fix-hexagon-gtest-on-hw branch May 11, 2022 20:18
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request May 16, 2022
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
shingjan pushed a commit to shingjan/tvm that referenced this pull request May 17, 2022
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Hexagon]Enabling gtest on Hexagon breaks skel library
3 participants