-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] capture gtest output and return over FFI #11239
Conversation
@adstraw how come this doesn't fail since we disabled gtest on hexagon? |
772d7ce
to
c20a060
Compare
Thought of a better solution that would allow us to land this PR before fixing #11237. Latest commit skips the unit tests if $USE_HEXAGON_GTEST is not set in the environment. This should allow CI to pass because we aren't currently setting that flag so test will be skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's test it on hardware CI as well before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* [Hexagon] capture gtest output and return over FFI * rename to test_hexagon_unit_tests.py so it will run in CI * rename to run_unit_tests.cc * pass back gtest error code along with gtest output * skip Hexagon unit tests if gtest not enabled * pass gtest_args as pytest argument * change env variable to HEXAGON_GTEST * set HEXAGON_GTEST in the environment to enable Hexagon unit tests * add back try / except around get_function
* [Hexagon] capture gtest output and return over FFI * rename to test_hexagon_unit_tests.py so it will run in CI * rename to run_unit_tests.cc * pass back gtest error code along with gtest output * skip Hexagon unit tests if gtest not enabled * pass gtest_args as pytest argument * change env variable to HEXAGON_GTEST * set HEXAGON_GTEST in the environment to enable Hexagon unit tests * add back try / except around get_function
* [Hexagon] capture gtest output and return over FFI * rename to test_hexagon_unit_tests.py so it will run in CI * rename to run_unit_tests.cc * pass back gtest error code along with gtest output * skip Hexagon unit tests if gtest not enabled * pass gtest_args as pytest argument * change env variable to HEXAGON_GTEST * set HEXAGON_GTEST in the environment to enable Hexagon unit tests * add back try / except around get_function
* [Hexagon] capture gtest output and return over FFI * rename to test_hexagon_unit_tests.py so it will run in CI * rename to run_unit_tests.cc * pass back gtest error code along with gtest output * skip Hexagon unit tests if gtest not enabled * pass gtest_args as pytest argument * change env variable to HEXAGON_GTEST * set HEXAGON_GTEST in the environment to enable Hexagon unit tests * add back try / except around get_function
Captures Hexagon gtest output in a string and passes back over the FFI. Captured output mimics standard gtest output:
cc @mehrdadh