[MetaSchedule] Update scripts for subgraph tuning #10501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
commented
Mar 6, 2022
| #define TVM_REGISTER_CUDA_TAG(Name, Arch, SharedMem, RegPerBlock) \ | ||
| TVM_REGISTER_TARGET_TAG(Name).set_config({ \ | ||
| {"kind", String("cuda")}, \ | ||
| {"arch", String(Arch)}, \ | ||
| {"shared_memory_per_block", Integer(SharedMem)}, \ | ||
| {"registers_per_block", Integer(RegPerBlock)}, \ | ||
| {"max_shared_memory_per_block", Integer(SharedMem)}, \ |
There was a problem hiding this comment.
Per discussion with @masahi, we updated shared_memory_per_block to max_shared_memory_per_block to be consistent with Vulkan settings. I'm not fully convinced but would love to follow the convention as Masa suggested.
junrushao
commented
Mar 6, 2022
| @@ -105,7 +105,6 @@ class VerifyGPUCodeNode : public PostprocNode { | |||
| Target target = context->target.value(); | |||
| this->target_constraints_ = Map<String, PrimExpr>{ | |||
| {"max_shared_memory_per_block", Extract(target, "shared_memory_per_block")}, | |||
| {"max_local_memory_per_block", Extract(target, "registers_per_block")}, | |||
ab6743d to
df45fe7
Compare
df45fe7 to
30af4b9
Compare
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.