Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyTorch grid_sample #10184

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Support PyTorch grid_sample #10184

merged 4 commits into from
Feb 8, 2022

Conversation

mei-ye
Copy link
Contributor

@mei-ye mei-ye commented Feb 8, 2022

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.



def test_list_tuple():
"""test compilation error for a Python list followed by a prim::TupleConstruct."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me more details on what this test is about? I don't see a relevant change in pytorch.py.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in PyTorch frontend on list of tuples. And the bug is now already fixed upstream. I removed my fix in this patch but decided to keep the unit test.

@masahi masahi self-assigned this Feb 8, 2022
@masahi masahi merged commit 98fcca1 into apache:main Feb 8, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
* [relay] Fix stack overflow in device_planner observed on windows due to recursive function calls.

* Revert "[relay] Fix stack overflow in device_planner observed on windows due to recursive function calls."

This reverts commit 7058136.

* [PyTorch] Add grid_sample with zeros and border padding mode for PyTorch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants