-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PyTorch grid_sample #10184
Support PyTorch grid_sample #10184
Conversation
…to recursive function calls.
…ows due to recursive function calls." This reverts commit 7058136.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @tmoreau89
|
||
|
||
def test_list_tuple(): | ||
"""test compilation error for a Python list followed by a prim::TupleConstruct.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give me more details on what this test is about? I don't see a relevant change in pytorch.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bug in PyTorch frontend on list of tuples. And the bug is now already fixed upstream. I removed my fix in this patch but decided to keep the unit test.
* [relay] Fix stack overflow in device_planner observed on windows due to recursive function calls. * Revert "[relay] Fix stack overflow in device_planner observed on windows due to recursive function calls." This reverts commit 7058136. * [PyTorch] Add grid_sample with zeros and border padding mode for PyTorch.
@masahi