Add temp git dir to test_cc_reviewers test case #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
approved these changes
Jan 26, 2022
driazati
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Thanks! This way of testing definitely makes more sense. Also just a note: if you add the text Fixes #10044 to your PR body GitHub will close the issue automatically once this is merged
|
Thanks @driazati I was not aware of that. |
|
Thanks @jacobbohlin @leandron @driazati . This is merged now! |
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
This decouples the test_cc_reviewers test case from the user's git configuration. The implementation reuses the TempGit structure from test_skip_ci to always use a fresh git environment.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This decouples the test_cc_reviewers test case from the user's git configuration. The implementation reuses the TempGit structure from test_skip_ci to always use a fresh git environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to decouple the
test_cc_reviewerstest case from the user's git configuration. The implementation reuses the TempGit structure fromtest_skip_cito always use a fresh git environment.Fixes #10044 which contains some additional information.