Don't explicitly link libgcc.a into libtvm_runtime.so on Android #10052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting Android toolchain via CMAKE_TOOLCHAIN_FILE also causes necessary flags to be added. Also, newer versions of the Android NDK no longer ship libgcc.a, so this takes care of that as well.
masahi
approved these changes
Jan 26, 2022
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
…che#10052) Setting Android toolchain via CMAKE_TOOLCHAIN_FILE also causes necessary flags to be added. Also, newer versions of the Android NDK no longer ship libgcc.a, so this takes care of that as well.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…che#10052) Setting Android toolchain via CMAKE_TOOLCHAIN_FILE also causes necessary flags to be added. Also, newer versions of the Android NDK no longer ship libgcc.a, so this takes care of that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting Android toolchain via
CMAKE_TOOLCHAIN_FILEalso causes necessary flags to be added. Also, newer versions of the Android NDK no longer shiplibgcc.a, so this takes care of that as well.